> On April 23, 2018, 2:44 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 61 (patched) > > <https://reviews.apache.org/r/66311/diff/6/?file=2007714#file2007714line61> > > > > This is not used here but I see it being used in r/66545 so just leave > > a comment.
Moved it there. > On April 23, 2018, 2:44 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.cpp > > Line 174 (original), 179 (patched) > > <https://reviews.apache.org/r/66311/diff/6/?file=2007716#file2007716line181> > > > > Actually, do we really need this? It seems that we can always get > > `registry` from `variable`? I just adopted it from the master registrar, and you are right in that it is not needed. On top of that it also introduces a lot of complicated state coupling between `variable` and `registry`, so removing it is a great suggestion. Code adjusted like suggested. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review201709 ----------------------------------------------------------- On April 23, 2018, 1:19 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66311/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 1:19 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8735 > https://issues.apache.org/jira/browse/MESOS-8735 > > > Repository: mesos > > > Description > ------- > > This patch adjusts the control flow of the resource provider manager > so that we can in the future make use of persisted resource provider > information. While this patch sets up the needed flow, it does not > implement recovery logic, yet. > > > Diffs > ----- > > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > src/resource_provider/registrar.hpp > 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 > src/resource_provider/registrar.cpp > 92ef9aecb1e93d10f46e53984391558f9901a60b > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66311/diff/7/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
