> On April 23, 2018, 2:53 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 215 (patched) > > <https://reviews.apache.org/r/66544/diff/2/?file=2006597#file2006597line215> > > > > In the master, we use `recovered` and `registered` to keep track of > > agents. Do you think it is better to keep track of `known` that is a > > superset of `subscribed`, or make it into two disjoint `recovered` and > > `subscribed` sets?
I believe that would only make sense for the sake of conformity with little benefit since otherwise the code here is pretty different from the master code. In the master this split makes sense since we might be dealing with a potentially huge number of agents and optimizing the size of the sets we need to examine can be benficial. Here expect a smaller number of resource providers, so the performance benefit would be outweight by simpler access to the data. Dropping for now, feel free to reopen. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66544/#review201710 ----------------------------------------------------------- On April 11, 2018, 11:23 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66544/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 11:23 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. > > > Bugs: MESOS-8402 > https://issues.apache.org/jira/browse/MESOS-8402 > > > Repository: mesos > > > Description > ------- > > This patch adds a data structure to bookkeep subscribed and recovered > resource providers in the ephemeral state of the resource provider > manager. > > > Diffs > ----- > > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > > > Diff: https://reviews.apache.org/r/66544/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
