----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201766 -----------------------------------------------------------
src/resource_provider/manager.cpp Lines 685 (patched) <https://reviews.apache.org/r/66545/#comment283351> Let's move the actual logic from r/66546 to this patch to make it self-contained. Also, what's your opinion on having a different error message for re-subscribing with an ID that has been removed? src/resource_provider/manager.cpp Lines 688 (patched) <https://reviews.apache.org/r/66545/#comment283350> It's probably just my personal preference, but based on the experience working on the codebase, i'd prefer `then` over `onAny` because the former gives the caller more control on error handling, rather than relying on the callee checking states. Please feel free to drop this if you think `onAny` is a better construct here. - Chun-Hung Hsiao On April 23, 2018, 11:19 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66545/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 11:19 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. > > > Bugs: MESOS-8402 > https://issues.apache.org/jira/browse/MESOS-8402 > > > Repository: mesos > > > Description > ------- > > Added admitted resource providers to the manager's registry. > > > Diffs > ----- > > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > src/resource_provider/registrar.cpp > 92ef9aecb1e93d10f46e53984391558f9901a60b > src/resource_provider/registry.proto > 14bd433ef056f8891e9a38153fdb06c39cee8f62 > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66545/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
