----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66608/#review201795 -----------------------------------------------------------
PASS: Mesos patch 66608 was successfully built and tested. Reviews applied: `['66608']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66608 - Mesos Reviewbot Windows On April 23, 2018, 9:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66608/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 9:52 p.m.) > > > Review request for mesos, Alexander Rukletsov and Michael Park. > > > Repository: mesos > > > Description > ------- > > While it was already possible to create a `hashmap` over move-only > values, we still performed a copy in `put`, making it hard to > dynamically add elements with the expected stout semantics. > > This patch relaxes the requirements on the value argument to `put` so > that instead of copyable we now only require move-constructible types. > > > Diffs > ----- > > 3rdparty/stout/include/stout/hashmap.hpp > 91085b8d8ad5d35c39c8cc95e3d4765d82d9a8db > > > Diff: https://reviews.apache.org/r/66608/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >