----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review201850 -----------------------------------------------------------
PASS: Mesos patch 66773 was successfully built and tested. Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', '66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', '66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', '66445', '66578', '66641', '66773']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66773 - Mesos Reviewbot Windows On April 24, 2018, 10:12 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66773/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 10:12 a.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Bugs: MESOS-8275 > https://issues.apache.org/jira/browse/MESOS-8275 > > > Repository: mesos > > > Description > ------- > > The functions `mode()`, `dev()`, and `inode()` are unused and do not > make sense on Windows, so they were explicitly deleted. The function > `mtime()` is used and has a logical mapping, `GetFileTime()`. However, > Windows reports time differently from POSIX, so a conversion must also > be performed such that the API `os::stat::mtime()` remains consistent > with its POSIX version. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/permissions.hpp > 453e60c7268db516c2c94501e11a92fe8f490498 > 3rdparty/stout/include/stout/os/windows/stat.hpp > c04953ee42f45dd80b6362fbeeddf4a0a20e7412 > 3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d > > > Diff: https://reviews.apache.org/r/66773/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
