> On April 23, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 683-692 (patched) > > <https://reviews.apache.org/r/66546/diff/5/?file=2009021#file2009021line683> > > > > Let's move this to r/66545.
I think this patch makes a lot of sense on its own, are you suggesting to drop it? > On April 23, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1160 (patched) > > <https://reviews.apache.org/r/66546/diff/5/?file=2009022#file2009022line1160> > > > > No need to create the master flag first since it is not used elsewhere. > > > > It also seems that we have this redundant step in all other tests. Cleaned up here in this patch; I'll add another patch to clean up the other instances. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201773 ----------------------------------------------------------- On April 24, 2018, 9:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66546/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 9:28 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-7558 > https://issues.apache.org/jira/browse/MESOS-7558 > > > Repository: mesos > > > Description > ------- > > This patch adds a check to the resource provider manager's subscribe > functionality making sure that any the ID sent by a resubscribing > resource provider corresponds to some previously known resource > provider. > > This not only serves as convenient validation of user-provided data, > but also makes sure that the internal state of the resource provider > manager remains consistent. > > > Diffs > ----- > > src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a > src/tests/resource_provider_manager_tests.cpp > c52541bf130ccf4795b989b53331176a64a097ea > > > Diff: https://reviews.apache.org/r/66546/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
