> On April 4, 2018, 10:22 a.m., Andrew Schwartzmeyer wrote: > > I think our other option is to just delete this file, and have > > `os/signals.hpp` include the POSIX version, but not the (deleted) Windows > > version, with a comment that none of it is (or will be) implemented. > > Joseph Wu wrote: > I'm in favor of this option. There are only a few places in the code > that use signals, but most of these are restricted to linux code only (the > notable exception being glog). We don't gain anything by leaving a bunch of > unimplemented stubs while ifdef-ing all occurences of said stubs.
Done. However, the two places where the header is wrapped in ifdefs are in libprocess and mesos, and I don't want to post reviews for them. I'll just fix it after this chain. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200467 ----------------------------------------------------------- On April 24, 2018, 1:41 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66444/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 1:41 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > ------- > > This file had never been included before, so it didn't compile. > Because everything in this file will remain unimplemented, we chose to > delete the Windows version of the file entirely. The POSIX > implementation is left intact in `stout/os/posix/signals.hpp`, and the > primary header, `stout/os/signals.hpp` is a no-op on Windows. We do > this so that its inclusion does not need to be guarded, only the use > of the POSIX-specific APIs under `os::signals`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/signals.hpp > 30e0f636647e5ddf7d6a2c4380eb0dc0b2428082 > 3rdparty/stout/include/stout/os/windows/signals.hpp > 0ed24771625e58c1de8b1aa96b70f5aae1638bd4 > > > Diff: https://reviews.apache.org/r/66444/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
