----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202050 -----------------------------------------------------------
Patch looks great! Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 66428, 66455, 66429, 66430, 66431, 66432, 66434, 66435, 66436, 66437, 66433, 66438, 66439, 66440, 66442, 66443, 66444, 66445, 66578, 66641, 66773, 66790, 66834, 66835, 66836] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66836/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 4:22 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Use the stout wrapper instead of `::socket` so we have built-in error > checking (and don't have to worry about types). > > > Diffs > ----- > > src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c > > > Diff: https://reviews.apache.org/r/66836/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
