----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66864/#review202109 -----------------------------------------------------------
Patch looks great! Reviews applied: [66864] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 29, 2018, 3:36 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66864/ > ----------------------------------------------------------- > > (Updated April 29, 2018, 3:36 a.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > Updated FrameworkInfo comparator to use protobuf MessageDifferencer. > > > Diffs > ----- > > include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa > include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb > src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 > src/tests/master_allocator_tests.cpp > e1aef8a9625a805e7ad2dfad37bfeedee82f160d > src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf > > > Diff: https://reviews.apache.org/r/66864/diff/1/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
