----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66790/#review202133 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/subprocess_tests.cpp Line 234 (original), 233 (patched) <https://reviews.apache.org/r/66790/#comment283769> I think the first half of this test could be out of the #ifdef. - Akash Gupta On April 24, 2018, 11:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66790/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 11:18 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph > Wu. > > > Bugs: MESOS-8833 > https://issues.apache.org/jira/browse/MESOS-8833 > > > Repository: mesos > > > Description > ------- > > These tests mostly "just worked" on Windows, with only minor changes, > such as converting POSIX shell-script to Batch or PowerShell, and > expecting Windows line-endings and quoting semantics. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > be99bd6a88b2abcabed8d4d16763c2e29f38eb14 > > > Diff: https://reviews.apache.org/r/66790/diff/1/ > > > Testing > ------- > > 13 more tests running on Windows :) > > > Thanks, > > Andrew Schwartzmeyer > >
