> On April 27, 2018, 6:04 p.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 288 (patched) > > <https://reviews.apache.org/r/66811/diff/2/?file=2014091#file2014091line288> > > > > This file should not be committed together with the changes to stout > > (project split). > > Andrew Schwartzmeyer wrote: > Why didn't the hooks catch this? > > Benjamin Bannier wrote: > They did for me, maybe you and Qian need to check how you apply patches > and whether your hooks are correctly set up and invoked.
Thanks for catching this! Not sure why the hooks did not catch it in the first place. I have moved that change to https://reviews.apache.org/r/66812/ - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/#review202058 ----------------------------------------------------------- On May 1, 2018, 10:23 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66811/ > ----------------------------------------------------------- > > (Updated May 1, 2018, 10:23 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. > > > Bugs: MESOS-8809 > https://issues.apache.org/jira/browse/MESOS-8809 > > > Repository: mesos > > > Description > ------- > > Added `libacl` as a dependency of stout. > > > Diffs > ----- > > 3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc > 3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da > 3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 > > > Diff: https://reviews.apache.org/r/66811/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
