----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202226 -----------------------------------------------------------
3rdparty/stout/include/stout/flags/parse.hpp Lines 197-200 (patched) <https://reviews.apache.org/r/66834/#comment283974> There should be a check for exactly 2 tokens here. Instead of using the `maxTokens` parameter of `strings::split`. The existing code would crash pretty easily. 3rdparty/stout/include/stout/flags/parse.hpp Lines 201 (patched) <https://reviews.apache.org/r/66834/#comment283975> I must be missing something... Where are `parse<HANDLE>` and `parse<SOCKET>` defined? - Joseph Wu On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66834/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 9:22 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Specialized `flags::parse<int_fd>`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/parse.hpp > eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 > > > Diff: https://reviews.apache.org/r/66834/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
