-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66858/#review202253
-----------------------------------------------------------



How about adding tests to validate that resources with providers are rejected?
```
growVolume.mutable_volume()->mutable_provider_id()->set_value("provider");
```
```
shrinkVolume.mutable_volume()->mutable_provider_id()->set_value("provider");
```

- Chun-Hung Hsiao


On April 27, 2018, 10:07 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66858/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 10:07 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-4945
>     https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for validation of `GrowVolume` and `ShrinkVolume`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 
> a5229610a81dfac9d358597135b63ee51de86659 
> 
> 
> Diff: https://reviews.apache.org/r/66858/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to