----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66904/#review202267 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On May 2, 2018, 12:34 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66904/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 12:34 p.m.) > > > Review request for mesos, Benjamin Bannier and Benno Evers. > > > Bugs: MESOS-8866 > https://issues.apache.org/jira/browse/MESOS-8866 > > > Repository: mesos > > > Description > ------- > > When building with 'Ninja', byproducts are used to resolve dependencies. > These have to be added for third-party dependencies. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb > > > Diff: https://reviews.apache.org/r/66904/diff/1/ > > > Testing > ------- > > Ran > ``` > mkdir build && cd build && > cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON && > ninja > ``` > and checked that `jemalloc` third-party dependency is build. > > > Thanks, > > Jan Schlicht > >
