----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/#review202317 -----------------------------------------------------------
Patch looks great! Reviews applied: [66912] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 2, 2018, 6:29 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66912/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 6:29 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8868 > https://issues.apache.org/jira/browse/MESOS-8868 > > > Repository: mesos > > > Description > ------- > > This fixes test failures on systems (like macOS) where `/tmp` is a > symlink. One such scenario is a test which makes a file in the > sandbox, then makes a symlink to the file, and finally compares the > realpath of the symlink to the file. If a part of the path of the > original file in the sandbox is a symlink, this will cause the test to > fail. The fact that the sandbox path is not a fully resolved file name > is confusing. By instead getting the `realpath` of the sandbox during > setup, we can fix the current test failures, and avoid future ones. > > > Diffs > ----- > > 3rdparty/stout/include/stout/tests/utils.hpp > bfbaa01514214c15f7d62742d37bfd8fa4514974 > > > Diff: https://reviews.apache.org/r/66912/diff/1/ > > > Testing > ------- > > stout-tests and libprocess-tests on a MacBook (mesos-tests is still building) > > > Thanks, > > Andrew Schwartzmeyer > >
