----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/#review202323 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_slave_reconciliation_tests.cpp Lines 371-372 (patched) <https://reviews.apache.org/r/66908/#comment284084> Nit: many of the tests we already have do this instead: ``` FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO; frameworkInfo.set_roles(0, DEFAULT_TEST_ROLE); ``` - Gaston Kleiman On May 2, 2018, 7:35 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66908/ > ----------------------------------------------------------- > > (Updated May 2, 2018, 7:35 a.m.) > > > Review request for mesos, Gaston Kleiman and Greg Mann. > > > Bugs: MESOS-8870 > https://issues.apache.org/jira/browse/MESOS-8870 > > > Repository: mesos > > > Description > ------- > > When the master receives an `UpdateSlaveMessage` after agent failover > it previously did not correctly detect dropped operations (operations > known to the master, but unknown to the agent) and did not trigger > reconciliation for such operations. > > This patch fixes the handler in the master so that such dropped > operations are reconciled. > > > Diffs > ----- > > src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 > src/tests/master_slave_reconciliation_tests.cpp > 6bb4263323bcfd191c8e3c1ccba10a240e9ddd83 > > > Diff: https://reviews.apache.org/r/66908/diff/1/ > > > Testing > ------- > > `make check` > > The test in this patch fails without the corresponding master change, but > succeeds with it applied. > > > Thanks, > > Benjamin Bannier > >
