----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66934/#review202359 -----------------------------------------------------------
Patch looks great! Reviews applied: [66932, 66933, 66934] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 3, 2018, 12:57 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66934/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 12:57 p.m.) > > > Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. > > > Bugs: MESOS-8774 > https://issues.apache.org/jira/browse/MESOS-8774 > > > Repository: mesos > > > Description > ------- > > Resource provider authentication is token-based and using a separate > realm. As a result, credential parameters have been removed from > 'MockResourceProvider'. Also, authentication for the resource provider > realm is disabled by default and only enabled in tests that instantiate > a Storage Local Resource Provider which support JWT. > > > Diffs > ----- > > src/tests/agent_resource_provider_config_api_tests.cpp > 6ced582e14966eea3bb109e2e2de0e554acc2968 > src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 > src/tests/executor_http_api_tests.cpp > 51cca7a90b3c5c5380ede0f17d66b9fdfeb88c27 > src/tests/master_tests.cpp d5ce52c0eb1ba333d1b3dd35518545c13d828ce6 > src/tests/mesos.hpp 756a52189ea3336b203ea1d606e2ba17762d57aa > src/tests/operation_reconciliation_tests.cpp > 76c169567de6e0ef99c984a673cd69ce7725d6b6 > src/tests/resource_provider_manager_tests.cpp > e8ca377fd0a927b99fdaf6a8ee0139025a41298e > src/tests/slave_tests.cpp ae82438a4f2f79820fe6d476e25b4915aa5f212c > src/tests/storage_local_resource_provider_tests.cpp > ccb114aacc904998dfeef4128f6d38dfb3c865c7 > > > Diff: https://reviews.apache.org/r/66934/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
