----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202364 -----------------------------------------------------------
docs/operator-http-api.md Lines 1987-1990 (patched) <https://reviews.apache.org/r/66923/#comment284189> Could you provide links to the persistent volume docs here and below for SHRINK_VOLUME? Since those docs provide lots of specific information about the API I think it would be helpful. docs/persistent-volume.md Lines 59-60 (original), 62-63 (patched) <https://reviews.apache.org/r/66923/#comment284166> Looks like this should also be updated? docs/persistent-volume.md Lines 271 (patched) <https://reviews.apache.org/r/66923/#comment284172> s/with same/with the same/ docs/persistent-volume.md Lines 309 (patched) <https://reviews.apache.org/r/66923/#comment284173> s/sending a/sending an/ docs/persistent-volume.md Lines 310 (patched) <https://reviews.apache.org/r/66923/#comment284174> If you're going to mention `acceptOffers` explicitly here, then we should also mention the ACCEPT call. Something like: "We can grow the persistent volume by including an `Offer::Operation` message when accepting an offer (this can be done via the `SchedulerDriver`'s `acceptOffers` method, or via the v1 scheduler API's `ACCEPT` call)." docs/persistent-volume.md Lines 311 (patched) <https://reviews.apache.org/r/66923/#comment284175> s/specified/specifies/ docs/persistent-volume.md Lines 312 (patched) <https://reviews.apache.org/r/66923/#comment284176> s/specified/specifies/ docs/persistent-volume.md Lines 317 (patched) <https://reviews.apache.org/r/66923/#comment284177> Nit: missing a space before the `{` on this line. Here and elsewhere. docs/persistent-volume.md Lines 347 (patched) <https://reviews.apache.org/r/66923/#comment284178> s/new size/the new size/ docs/persistent-volume.md Lines 384 (patched) <https://reviews.apache.org/r/66923/#comment284179> s/IN/In/ docs/persistent-volume.md Lines 415 (patched) <https://reviews.apache.org/r/66923/#comment284180> s/sending a/sending an/ docs/persistent-volume.md Lines 416 (patched) <https://reviews.apache.org/r/66923/#comment284181> Ditto regarding mentioning `acceptOffers` here. docs/persistent-volume.md Lines 417-418 (patched) <https://reviews.apache.org/r/66923/#comment284182> s/specified/specifies/ docs/persistent-volume.md Lines 447 (patched) <https://reviews.apache.org/r/66923/#comment284183> s/new size/the new size/ docs/persistent-volume.md Lines 489-497 (patched) <https://reviews.apache.org/r/66923/#comment284156> Could you also include these restrictions in the docs for the new operator API calls that you're adding? docs/persistent-volume.md Lines 496-497 (patched) <https://reviews.apache.org/r/66923/#comment284157> Suggestion: "Volume resize operations cannot be included in an ACCEPT call with other operations which make use of the resized volume." docs/persistent-volume.md Lines 500 (patched) <https://reviews.apache.org/r/66923/#comment284184> To better distinguish this heading and the next, I would recommend: "Versioned HTTP Operator API" docs/persistent-volume.md Lines 508 (patched) <https://reviews.apache.org/r/66923/#comment284158> s/volume/volumes/ docs/persistent-volume.md Lines 511-512 (patched) <https://reviews.apache.org/r/66923/#comment284188> I would recommend removing this statement, since it is already mentioned in the next section. docs/persistent-volume.md Lines 515 (patched) <https://reviews.apache.org/r/66923/#comment284185> To better distinguish this heading from the preceding one, I would recommend: "Unversioned Operator HTTP Endpoints" docs/persistent-volume.md Lines 520 (patched) <https://reviews.apache.org/r/66923/#comment284186> s/encourage to use/encourage operators to use the/ docs/persistent-volume.md Lines 521 (patched) <https://reviews.apache.org/r/66923/#comment284187> s/and new/as new/ - Greg Mann On May 3, 2018, 12:01 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66923/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 12:01 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Added documentation on volume resize support. > > > Diffs > ----- > > docs/authorization.md fdbef770c38ab38ab748b4f943b331d4442a2ce1 > docs/operator-http-api.md 9be1e2db60562b369bdc6ee2c732a74fad049580 > docs/persistent-volume.md 1a5799b8d8e5302e0b01da6b9a16a3b9fb75c898 > > > Diff: https://reviews.apache.org/r/66923/diff/1/ > > > Testing > ------- > > https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/persistent-volume.md > https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/operator-http-api.md > https://github.com/zhitaoli/mesos/blob/zhitao/public/volume_resize_mesos_4965_speculative/docs/authorization.md > > > Thanks, > > Zhitao Li > >
