----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66634/#review202421 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On April 16, 2018, 8:03 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66634/ > ----------------------------------------------------------- > > (Updated April 16, 2018, 8:03 a.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-8786 > https://issues.apache.org/jira/browse/MESOS-8786 > > > Repository: mesos > > > Description > ------- > > This patch adds `override` keywords to functions overriding `virtual` > base class functions. This explicitness helps in a subsequent patch in > refactoring the `Subsystem` base class interface. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp > ebddf4e9812c7e1eecec99215dfa5fd8e4e6e361 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp > 282a76189579d3ddd61f4aad210ce8e876ff0c25 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.hpp > e4977da476a04a708a2e9b9dcc5a2f85da5867f4 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuset.hpp > b5d712a8eb8ba74092184024e3b40ad9ba1b7584 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.hpp > 4ab224e3b55a9d2b37d5e9abe94c069d89cd6d80 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/hugetlb.hpp > 27407133e7315dccf1efe2440cc1bf79c51e7dca > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > d79fda3cf852e50e75dbeeeaeae50b1f471a55a4 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_cls.hpp > bcaa16142c4e9882dea88e70095cfb7f223401ef > src/slave/containerizer/mesos/isolators/cgroups/subsystems/net_prio.hpp > 002c689503d45622cba437c851561f5ec7dc8a12 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.hpp > 14c0e79f045fb826d20e476772e017439977dded > src/slave/containerizer/mesos/isolators/cgroups/subsystems/pids.hpp > cb6c91920355d3d5599f8a3cf0ce2ac5eee18d37 > > > Diff: https://reviews.apache.org/r/66634/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
