----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66947/#review202462 -----------------------------------------------------------
Patch looks great! Reviews applied: [66947] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 4, 2018, 9:32 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66947/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 9:32 a.m.) > > > Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod > Kone. > > > Bugs: MESOS-8876 > https://issues.apache.org/jira/browse/MESOS-8876 > > > Repository: mesos > > > Description > ------- > > Previously after the container process is reaped by the Docker > executor, we will wait 3 seconds for `reaped` to be invoked. > However in some cases (e.g., launch a Docker container to use > an external rexray volume), there will be more than 3 seconds > after the container process exits and before the `docker run` > command returns (i.e., `reaped` invoked). So in this patch, > the timeout is increased to 60 seconds. > > > Diffs > ----- > > src/docker/executor.cpp 16509dae3acebc59635e925073372adfb3786edc > > > Diff: https://reviews.apache.org/r/66947/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
