----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66952/#review202463 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/fd.hpp Lines 183 (patched) <https://reviews.apache.org/r/66952/#comment284291> Shouldn't the overlapped_ member be constant? - Eric Mumau On May 4, 2018, 5:15 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66952/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 5:15 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8670 and MESOS-8674 > https://issues.apache.org/jira/browse/MESOS-8670 > https://issues.apache.org/jira/browse/MESOS-8674 > > > Repository: mesos > > > Description > ------- > > Added an field to WindowsFD for functions that need to know if a > Windows file is opened in overlapped mode, such as `os::read`, since > Windows doesn't provide a Win32 API for it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/fd.hpp > bab16e869e69c214e18de584d1615311316e001a > 3rdparty/stout/include/stout/os/windows/open.hpp > 701dcec7c4c1162d38d8f25596af29ed3b32691d > > > Diff: https://reviews.apache.org/r/66952/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
