----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66954/#review202504 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/io.hpp Lines 175 (patched) <https://reviews.apache.org/r/66954/#comment284374> Can this be used to return Result<size_t> instead - Radhika Jandhyala On May 4, 2018, 5:21 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66954/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 5:21 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8670 > https://issues.apache.org/jira/browse/MESOS-8670 > > > Repository: mesos > > > Description > ------- > > Added a helper file for io, because `os::read/write` need to work on > both non-overlapped and overlapped files, so the logic has gotten > more complicated. The new file, `io.hpp`, has all the shared logic. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am f2e60224d9c729497bbcfffbec989c4f355d8f85 > 3rdparty/stout/include/stout/os/windows/io.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/66954/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
