----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66956/#review202582 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/write.hpp Lines 23-29 (patched) <https://reviews.apache.org/r/66956/#comment284431> Same question, should this be a public API? 3rdparty/stout/include/stout/os/windows/write.hpp Line 29 (original), 32 (patched) <https://reviews.apache.org/r/66956/#comment284432> Hm. Maybe `read_write_async` should be `read_async` and `write_async` internally so we don't have to throw away the constness here. - Andrew Schwartzmeyer On May 4, 2018, 10:21 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66956/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 10:21 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8670 > https://issues.apache.org/jira/browse/MESOS-8670 > > > Repository: mesos > > > Description > ------- > > Added overlapped handle support to `os::write`. Now, `os::write` will do > a blocking write no matter the handle type. Also, `os::write_async` will > do an overlapped write on an overlapped handle. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/write.hpp > 295c031c5824d13d74e2c9006e62c391d5020f69 > > > Diff: https://reviews.apache.org/r/66956/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
