----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66957/#review202585 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/pipe.hpp Lines 35-36 (original), 36-37 (patched) <https://reviews.apache.org/r/66957/#comment284451> Why do we choose to default to overlapped here? - Andrew Schwartzmeyer On May 4, 2018, 10:20 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66957/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 10:20 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8674 > https://issues.apache.org/jira/browse/MESOS-8674 > > > Repository: mesos > > > Description > ------- > > `os::pipe` was using `CreatePipe`, which does not support overlapped > io. Now, the implementation of `os::pipe` has been changed to use > `CreateNamedPipe`, which supports overlapped IO. The named pipe is > created with an unique random name, so it is effectively anonymous. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/pipe.hpp > a3574fd6f2ff1608396b47cad8cbed88134a74ca > > > Diff: https://reviews.apache.org/r/66957/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
