----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66960/#review202587 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 27-31 (patched) <https://reviews.apache.org/r/66960/#comment284457> Should this be a public API? 3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 36-43 (patched) <https://reviews.apache.org/r/66960/#comment284458> nit: `s/res/result` for consistency with other code. 3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 37-43 (patched) <https://reviews.apache.org/r/66960/#comment284459> I had to pull up the docs to check a few of these arguments; perhaps we should document them inline. 3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 45 (patched) <https://reviews.apache.org/r/66960/#comment284460> You can just replace this with a `WindowsError` and check `error.code`. Note that deleting `WindowsSocketError` is a pending TODO because `WSAGetLastError` and `GetLastError` are the same function. You can also just use `WindowsSocketError` so that we're consistent until we take care of that TODO, but either way you don't have to manually call `GetLastError`. 3rdparty/stout/include/stout/os/windows/sendfile.hpp Lines 82 (patched) <https://reviews.apache.org/r/66960/#comment284461> Shouldn't this return `result.error()`? - Andrew Schwartzmeyer On May 4, 2018, 10:18 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66960/ > ----------------------------------------------------------- > > (Updated May 4, 2018, 10:18 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8681 > https://issues.apache.org/jira/browse/MESOS-8681 > > > Repository: mesos > > > Description > ------- > > Broke the original `os::sendfile` implementation into an asynchronous > `os::sendfile_async`function and a synchronous `os::sendfile` function. > The synchronous version simply calls the asynchronous version and waits. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > 594d9c7beeff2766f59f16ba25986314f2f7ceb8 > > > Diff: https://reviews.apache.org/r/66960/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
