> On May 8, 2018, 12:08 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163 (patched) > > <https://reviews.apache.org/r/66919/diff/3/?file=2017559#file2017559line4163> > > > > You missed a space between `result)` and `{` which I didn't catch > > initially but fixed up in a subsequent commit.
Thanks for the follow up commit - Xudong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202606 ----------------------------------------------------------- On May 7, 2018, 6:10 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66919/ > ----------------------------------------------------------- > > (Updated May 7, 2018, 6:10 p.m.) > > > Review request for mesos, Joseph Wu and Jiang Yan Xu. > > > Bugs: MESOS-8630 > https://issues.apache.org/jira/browse/MESOS-8630 > > > Repository: mesos > > > Description > ------- > > When the registrar fails to update the registry it would abort the > actor and fail all future operations,However when the registrar > updates is requested by an operator API such as maintenance update, > the master process doesn't shut down (a 500 error is returned to the > client instead)and all subsequent operations will fail. > > Review: https://reviews.apache.org/r/66919 > > > Diffs > ----- > > src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad > > > Diff: https://reviews.apache.org/r/66919/diff/3/ > > > Testing > ------- > > xujyan made a local test change to verify this patch: > https://github.com/xujyan/mesos/commit/68051320a87431f6d2f3fbad6b0b97814200a731 > > Test output: > F0504 20:43:36.530680 1858991 http.cpp:4304] CHECK_READY(result): is FAILED: > Failed to update registry: Failed to perform store within 5secs > > > Thanks, > > Xudong Ni > >
