----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66932/#review202622 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/v1/resource_provider.hpp Line 83 (original), 83 (patched) <https://reviews.apache.org/r/66932/#comment284537> Could you update the docstring to include `token` both in the description text and the param list? it would be great to also document the expected semantics of the passed `string`. - Benjamin Bannier On May 3, 2018, 2:55 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66932/ > ----------------------------------------------------------- > > (Updated May 3, 2018, 2:55 p.m.) > > > Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. > > > Bugs: MESOS-8774 > https://issues.apache.org/jira/browse/MESOS-8774 > > > Repository: mesos > > > Description > ------- > > If a token is provided, it will be used in HTTP requests to the resource > provider manager. This allows JWT based authentication and authorization > for resource providers. > The (unimplemented) credential support in `resource_provider::Driver` > has been removed in favor of the token-based approach. > > > Diffs > ----- > > include/mesos/v1/resource_provider.hpp > 787c619cb6d7574c3ffcd22c5ad2f3a6a3b56694 > src/resource_provider/driver.cpp 70b7e3244a18dd854a85c65853fe32d82a5ec7d4 > src/resource_provider/http_connection.hpp > 0ae8124150dff96296a4a2c358338fe196717b1a > src/resource_provider/storage/provider.cpp > d1267cf8df06cc758c47d47535b868a3ac741a0b > src/tests/mesos.hpp 756a52189ea3336b203ea1d606e2ba17762d57aa > > > Diff: https://reviews.apache.org/r/66932/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
