-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67003/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-8892
https://issues.apache.org/jira/browse/MESOS-8892
Repository: mesos
Description
-------
The test `ReconcileDroppedOperation` uses detection of a
`ReconcileOperationsMessage` to confirm correct agent reregistration
behavior. For that it drops an operation on its way to the agent, and
then tries to observe the `ReconcileOperationsMessage` when the agent
reregisters after a simulated master failover.
Since `ReconcileOperationsMessage` is sent whenever the master detects
discrepancy between its own operation state of the agent and the
information sent by the agent in an `UpdateSlaveMessage` we need to
make sure to only drop the operation once the agent has sent the
update which is part of its initial registration sequence.
Diffs
-----
src/tests/master_slave_reconciliation_tests.cpp
937bab08c9bef1a2a6a400979dcf0895412168f5
Diff: https://reviews.apache.org/r/67003/diff/1/
Testing
-------
`make check`
Ran the test in repetition under heavy (simulated) load for several thousand
iterations without failing; before this patch it would fail after a couple
dozen iterations.
Thanks,
Benjamin Bannier
