----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66821/#review202663 -----------------------------------------------------------
There's a typo in the RR description: s/framwork/framework/ src/master/metrics.hpp Lines 226-227 (patched) <https://reviews.apache.org/r/66821/#comment284602> This is done in https://reviews.apache.org/r/66882/, can we squash both patches? - Gaston Kleiman On April 30, 2018, 11:41 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66821/ > ----------------------------------------------------------- > > (Updated April 30, 2018, 11:41 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added framwork metrics helper normalize() and getPrefix(). > > > Diffs > ----- > > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66821/diff/3/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
