> On May 8, 2018, 12:35 p.m., Benjamin Bannier wrote: > > src/slave/constants.hpp > > Lines 171 (patched) > > <https://reviews.apache.org/r/66933/diff/2/?file=2017498#file2017498line171> > > > > I don't believe it makes sense to treat resource providers separately > > from other internal components using HTTP communication, what about e.g., > > > > // Name of the agent HTTP authentication realm for internal Mesos > > components. > > constexpr char INTERNAL_HTTP_AUTHENTICATION_REALM[] = > > "mesos-internal"; > > Jan Schlicht wrote: > While the resource provider API currently is only used internally, it's > expected to be used externally as well. If it would be internal only, we > would communicate using actors.
Good point about about external resource providers. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66933/#review202623 ----------------------------------------------------------- On May 7, 2018, 2:12 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66933/ > ----------------------------------------------------------- > > (Updated May 7, 2018, 2:12 p.m.) > > > Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. > > > Bugs: MESOS-8774 > https://issues.apache.org/jira/browse/MESOS-8774 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf > src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 > src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 > > > Diff: https://reviews.apache.org/r/66933/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
