----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66510/#review202736 -----------------------------------------------------------
src/slave/containerizer/composing.cpp Line 375 (original), 377 (patched) <https://reviews.apache.org/r/66510/#comment284717> Not yours, but `after launch returned false` seems not correct to me since launch does not return true/false anymore. So it should be something like `after launch returned NOT_SUPPORTED`? src/slave/containerizer/composing.cpp Line 516 (original), 519 (patched) <https://reviews.apache.org/r/66510/#comment284718> Ditto. - Qian Zhang On April 9, 2018, 11:44 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66510/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 11:44 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8706 > https://issues.apache.org/jira/browse/MESOS-8706 > > > Repository: mesos > > > Description > ------- > > This patch changes the return type of `destroy()` method for all > containerizers. As a result, `destroy()` and `wait()` methods have > got the same signature and return type. In fact, all these methods > depend on the same container termination promise, so this unification > makes both containerizer interface and internal logic more consistent. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > 1221d9b61b7cfbdbaa560dbafb0158225331ed6d > src/slave/containerizer/composing.cpp > cd840a5409023d32701329bf37806f2e7ed6ffd2 > src/slave/containerizer/containerizer.hpp > 836283aa8aa827459558d567e090a230c32351ed > src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 > src/slave/containerizer/docker.cpp 31d64a7ea2a331a084c0f1707b82e938dfe6390f > src/slave/containerizer/mesos/containerizer.hpp > cba4ed2e20622070b46071f35907d8b32c25b2fc > src/slave/containerizer/mesos/containerizer.cpp > 7473a871e626833733f39375b778aff70529dc63 > src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd > > > Diff: https://reviews.apache.org/r/66510/diff/2/ > > > Testing > ------- > > Tests can't be compiled after this change. > See the next patch in the chain. > > > Thanks, > > Andrei Budnik > >
