----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66997/#review202740 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/Makefile.am Lines 218-221 (patched) <https://reviews.apache.org/r/66997/#comment284723> Thanks for adding the comment. 3rdparty/libprocess/configure.ac Lines 1164 (patched) <https://reviews.apache.org/r/66997/#comment284722> We should be able to use `GRPC_VARIANT` here as well as the name should not collide with what we do on the automake side. - Benjamin Bannier On May 9, 2018, 2:52 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66997/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 2:52 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8798 > https://issues.apache.org/jira/browse/MESOS-8798 > > > Repository: mesos > > > Description > ------- > > When the SSL build feature is disabled, libprocess now builds > `libgrpc_unsecure` and `libgrpc++_unsecure` instead of `libgrpc` and > `libgrpc++`, so the SSL headers and libraries are no longer required. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 7fb77f8f29e00a276cfb0efc5324ac838c8b5176 > 3rdparty/libprocess/Makefile.am 70edb2ec3ad8b222cd28064f1012c39c335c57a5 > 3rdparty/libprocess/configure.ac fd65d7062ee42eccf2a68d23d02e456d07da6513 > > > Diff: https://reviews.apache.org/r/66997/diff/2/ > > > Testing > ------- > > sudo make check in Mesos build and libprocess standalone build, with openssl > 1.0.2l and 1.1.0f. > > > Thanks, > > Chun-Hung Hsiao > >
