----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66882/#review202761 -----------------------------------------------------------
Fix it, then Ship it! src/master/metrics.hpp Lines 282-283 (original), 282-286 (patched) <https://reviews.apache.org/r/66882/#comment284751> Nit: two newlines between these. - Greg Mann On May 9, 2018, 12:06 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66882/ > ----------------------------------------------------------- > > (Updated May 9, 2018, 12:06 a.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Greg Mann, and Vinod > Kone. > > > Repository: mesos > > > Description > ------- > > Added `normalizeMetricKey()` and `getFrameworkMetricPrefix()`. > > > Diffs > ----- > > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66882/diff/2/ > > > Testing > ------- > > > Thanks, > > Gaston Kleiman > >
