----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66669/#review202819 -----------------------------------------------------------
Ship it! src/slave/containerizer/composing.cpp Line 358 (original), 358-363 (patched) <https://reviews.apache.org/r/66669/#comment284806> So besides removing the container from the `containers_` map, we also eliminate a call to `ComposingContainerizerProcess::destroy()`, My understanding is we assume the underlying containerizer (Mesos/Docker containerizer) will always do the destroy, so here in composing containerizer we just need to remove the container from the `containers_` map. If so, can you please update the commit message for that? - Qian Zhang On April 17, 2018, 11:23 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66669/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 11:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8714 > https://issues.apache.org/jira/browse/MESOS-8714 > > > Repository: mesos > > > Description > ------- > > This patch adds callbacks on `wait()` and `destroy()` in composing > containerizer to remove a container from the `containers_` map after > the container's termination. > > > Diffs > ----- > > src/slave/containerizer/composing.cpp > 186102c66d373dcd799cadd9fed7d1c8cb894971 > > > Diff: https://reviews.apache.org/r/66669/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
