-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67055/
-----------------------------------------------------------
(Updated mai 11, 2018, 9:49 après-midi)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung,
and Kevin Klues.
Changes
-------
Changed Python version.
Bugs: MESOS-8770
https://issues.apache.org/jira/browse/MESOS-8770
Repository: mesos
Description
-------
The Python 3 supports scripts currently live in support/python3.
Once all support scripts will have been updated to Python 3 and
tested by the developers, we will replace the Python 2 scripts by
the new ones in an ongoing effort of modernizing our Python codebase.
Diffs (updated)
-----
support/python3/cpplint.patch PRE-CREATION
support/python3/cpplint.py PRE-CREATION
Diff: https://reviews.apache.org/r/67055/diff/2/
Changes: https://reviews.apache.org/r/67055/diff/1-2/
Testing
-------
Used `mesos-style.py` with the old `cpplint.py` (no change on `mesos-style.py`):
```
apache-mesos (cpplint) $ ./support/mesos-style.py
Checking 1289 C++ files
Total errors found: 0
Checking 4 JavaScript files
Total errors found: 0
Checking 47 Python files
py27-lint: commands succeeded
congratulations :)
py27-lint: commands succeeded
congratulations :)
Total errors found: 0
```
Updated `mesos-style.py` to use the new version of cpplint:
```
# We do not use a version of cpplint available through pip as
# we use a custom version (see cpplint.path) to lint C++ files.
process = subprocess.Popen(
['python3', 'support/python3/cpplint.py', rules_filter] +
source_paths,
stderr=subprocess.PIPE,
close_fds=True)
```
Run `mesos-style.py` again:
```
apache-mesos (cpplint) $ ./support/mesos-style.py
Checking 1289 C++ files
Total errors found: 0
Checking 4 JavaScript files
Total errors found: 0
Checking 47 Python files
py27-lint: commands succeeded
congratulations :)
py27-lint: commands succeeded
congratulations :)
************* Module mesos-style
C:279, 0: Line too long (83/80) (line-too-long)
Total errors found: 1
```
As we can see, the number of errors found by cpplint is the same as before.
I have also used cpplint separately bu running `python3
support/python3/cpplint` on a few C++ files to see that it was running as
expected.
Thanks,
Armand Grillet
