----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66990/#review203016 -----------------------------------------------------------
src/master/flags.cpp Lines 699-705 (patched) <https://reviews.apache.org/r/66990/#comment285064> I am having some trouble coming up with a mental picture of what is supposed to happen with this flag enabled from this text alone. I believe we need to better document what the expected behavior is (a ticket describing the expected behavior would have already gone some way -- TBH, I am surprised we don't use tickets to track such important work), especially since the current allocator is already a black box which "just works", and misbehavior is often hard to track down for users. I would be interested in e.g., * Does the new behavior temporarily violate fairness? If yes, in what manner do we expect to approach fairness again? * What is the effect of this flag on the typical time it takes a framework to receive an offer? Related, are frameworks required to use adjusted offer suppression protocols with this flag enabled to make sure they can revive again? * ... It would be great to give users some mental framework on how to think about the allocator with this flag on. Here might be one location to start. - Benjamin Bannier On May 7, 2018, 10:33 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66990/ > ----------------------------------------------------------- > > (Updated May 7, 2018, 10:33 p.m.) > > > Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This flag instructs the default allocator to exhaustively allocate > declined resources to all frameworks before reallocating the > resources back to the decliner. That is, if a framework declines > some resources from an agent the allocator will attempt to allocate > _some_ resources from that agent to every other framework _before_ > reallocating any resources from that agent back to the decliner. > > > Diffs > ----- > > src/master/flags.hpp 4715f2bf4eb62808265f3062f93e370faa53e63d > src/master/flags.cpp 4ad13752719daf2cfad1f578edffc1f16a101760 > src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 > > > Diff: https://reviews.apache.org/r/66990/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
