> On May 14, 2018, 2:09 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Lines 797-802 (patched) > > <https://reviews.apache.org/r/67075/diff/1/?file=2019562#file2019562line805> > > > > Instead of this Windows code to construct the path to the exe, you can > > just use: > > > > ``` > > path::join(BUILD_DIR, "test-echo.exe") > > ``` > > > > (See the use of this in `process_tests.cpp` for `test-linkee` as an > > example.) > > Radhika Jandhyala wrote: > BUILD_DIR does not contain "debug" or "release" which is where the exes > get placed
Oh goodness... all those tests in `process_tests.cpp` that use it are disabled... I see. Okay, we should probably fix `BUILD_DIR` then to be correct, if possible. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67075/#review203066 ----------------------------------------------------------- On May 10, 2018, 3:24 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67075/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 3:24 p.m.) > > > Review request for Andrew Schwartzmeyer. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-8857 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-8857 > > > Repository: mesos > > > Description > ------- > > Fix TEST_F(SubprocessTest, Flags) > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/CMakeLists.txt > 1b2d75d2b576e528db49635fce54174d56a29c59 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 269918e7f795bb62f8acd84cfc4233ff8682f90d > 3rdparty/libprocess/src/tests/test_flags.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67075/diff/1/ > > > Testing > ------- > > [----------] 18 tests from SubprocessTest > [ RUN ] SubprocessTest.PipeOutputToFileDescriptor > [ OK ] SubprocessTest.PipeOutputToFileDescriptor (38 ms) > [ RUN ] SubprocessTest.PipeOutputToPath > [ OK ] SubprocessTest.PipeOutputToPath (33 ms) > [ RUN ] SubprocessTest.EnvironmentEcho > [ OK ] SubprocessTest.EnvironmentEcho (22 ms) > [ RUN ] SubprocessTest.Status > [ OK ] SubprocessTest.Status (29 ms) > [ RUN ] SubprocessTest.PipeOutput > [ OK ] SubprocessTest.PipeOutput (25 ms) > [ RUN ] SubprocessTest.PipeLargeOutput > [ OK ] SubprocessTest.PipeLargeOutput (18 ms) > [ RUN ] SubprocessTest.PipeInput > [ OK ] SubprocessTest.PipeInput (248 ms) > [ RUN ] SubprocessTest.PipeRedirect > [ OK ] SubprocessTest.PipeRedirect (31 ms) > [ RUN ] SubprocessTest.PathOutput > [ OK ] SubprocessTest.PathOutput (54 ms) > [ RUN ] SubprocessTest.PathInput > [ OK ] SubprocessTest.PathInput (232 ms) > [ RUN ] SubprocessTest.FdOutput > [ OK ] SubprocessTest.FdOutput (45 ms) > [ RUN ] SubprocessTest.FdInput > [ OK ] SubprocessTest.FdInput (237 ms) > [ RUN ] SubprocessTest.Default > hello world > [ OK ] SubprocessTest.Default (21 ms) > [ RUN ] SubprocessTest.Flags > [ OK ] SubprocessTest.Flags (34 ms) > [ RUN ] SubprocessTest.Environment > [ OK ] SubprocessTest.Environment (32 ms) > [ RUN ] SubprocessTest.EnvironmentWithSpaces > [ OK ] SubprocessTest.EnvironmentWithSpaces (19 ms) > [ RUN ] SubprocessTest.EnvironmentWithSpacesAndQuotes > [ OK ] SubprocessTest.EnvironmentWithSpacesAndQuotes (17 ms) > [ RUN ] SubprocessTest.EnvironmentOverride > [ OK ] SubprocessTest.EnvironmentOverride (17 ms) > [----------] 18 tests from SubprocessTest (1201 ms total) > > > Thanks, > > Radhika Jandhyala > >
