----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67128/#review203117 -----------------------------------------------------------
PASS: Mesos patch 67128 was successfully built and tested. Reviews applied: `['66668', '66670', '66671', '66817', '67128']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67128 - Mesos Reviewbot Windows On May 15, 2018, 11:02 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67128/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 11:02 a.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian > Zhang. > > > Bugs: MESOS-8829 > https://issues.apache.org/jira/browse/MESOS-8829 > > > Repository: mesos > > > Description > ------- > > Previously, `wait()` and `destroy()` containerizer methods returned > different types, so it was necessarry to call `wait()` before calling > `destroy()` to get the process's exit status. Now, as both methods > return `ContainerTermination`, we can get rid of redundant `wait()` > calls. > > > Diffs > ----- > > src/tests/cluster.cpp b56212f6529a4d307e65797ad9bb34f2104fc832 > src/tests/containerizer/docker_containerizer_tests.cpp > e37a9c11fe67846ceeeb6cfbf8a75d1e5753e185 > src/tests/containerizer/io_switchboard_tests.cpp > 784386ab21a6e7841dd13f5ef9e63fee65a474ee > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > bf0471188345d36c8fbe402132189137384c0801 > src/tests/containerizer/mesos_containerizer_tests.cpp > 01f2b38cfa67b144298c361e92170322864ac201 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > 661be81d6036113295876546f565264b843b704d > src/tests/containerizer/volume_image_isolator_tests.cpp > 3aa19e2108e6eebe3f16d16c9fbee601c1513eb3 > src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp > 0400052a1c73ccc15c932c573cfb324ca83e2e59 > src/tests/containerizer/volume_secret_isolator_tests.cpp > 56691aed9d40373e74c8425ebed006d31c2233de > src/tests/slave_recovery_tests.cpp afe8b8a6cc21421a37164016d7fe01bf96a559da > > > Diff: https://reviews.apache.org/r/67128/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
