----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203154 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp Lines 481 (patched) <https://reviews.apache.org/r/67137/#comment285230> This kind of logic will _never_ work on Windows, because the file descriptors are actually handles, and you can't just iterate through all open handles. src/slave/containerizer/mesos/launch.cpp Lines 1110-1113 (patched) <https://reviews.apache.org/r/67137/#comment285232> Why not just `O_CLOEXEC` all the handles opened on Linux (so that you can avoid all this kind of hacky logic here)? (And fix the third-party libs to do the same.) - Andrew Schwartzmeyer On May 15, 2018, 9:19 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67137/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 9:19 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and James Peach. > > > Bugs: MESOS-8917 > https://issues.apache.org/jira/browse/MESOS-8917 > > > Repository: mesos > > > Description > ------- > > Avoided leaking file descriptors in Mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > f25d90651ef32495c9161c3eaed8a327d1b2b926 > > > Diff: https://reviews.apache.org/r/67137/diff/1/ > > > Testing > ------- > > `make check` > > I still need to confirm this patch in CI on a wider range of scenarios. > > > Thanks, > > Benjamin Bannier > >
