----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203290 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67155. Failed command: `python.exe .\support\apply-reviews.py -n -r 67155` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67157 Relevant logs: - [apply-review-67155-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67157/logs/apply-review-67155-stdout.log): ``` error: patch failed: 3rdparty/libprocess/src/tests/grpc_tests.cpp:124 error: 3rdparty/libprocess/src/tests/grpc_tests.cpp: patch does not apply ``` - Mesos Reviewbot Windows On May 16, 2018, 8:49 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67157/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 8:49 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and > Zhitao Li. > > > Bugs: MESOS-8924 > https://issues.apache.org/jira/browse/MESOS-8924 > > > Repository: mesos > > > Description > ------- > > The refactoring does the following things: > 1. Manage the gRPC completion queue and the looper thread in the runtime > process to get rid of a lock in `Runtime::Data`. > 2. Move the computation of sending a request into the runtime process. > 3. Let libprocess manage the runtime process automatically instead of > managing its lifecycle in `Runtime::Data`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/grpc.hpp > 321a46e19c69eafb24012bcef68bb8b0cc6aa436 > 3rdparty/libprocess/src/grpc.cpp a80bcb614ec96d92d21bc88a281d3208e86141a0 > > > Diff: https://reviews.apache.org/r/67157/diff/2/ > > > Testing > ------- > > make check in libprocess > > NOTE: Mesos cannot be built with this patch standalone. The tests are done > later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
