> On May 17, 2018, 11:07 p.m., James Peach wrote: > > src/posix/rlimits.cpp > > Lines 147 (patched) > > <https://reviews.apache.org/r/67136/diff/1/?file=2023057#file2023057line147> > > > > Use `ErrnoError` (also in the rest of the file if you feel like it).
Done, also snuck in a fix for the one above. > On May 17, 2018, 11:07 p.m., James Peach wrote: > > src/posix/rlimits.cpp > > Lines 155 (patched) > > <https://reviews.apache.org/r/67136/diff/1/?file=2023057#file2023057line155> > > > > I expected that RVO would kick in and eliminate the copy here? This function is not a candidate for NRVO as the type of `limit` is different from the functions return value type (`RLimitInfo::RLimit` vs. `Try<RLimitInfo::RLimit>). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203373 ----------------------------------------------------------- On May 18, 2018, 2:36 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67136/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 2:36 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Repository: mesos > > > Description > ------- > > Added a function to get rlimits. > > > Diffs > ----- > > src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da > src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d > > > Diff: https://reviews.apache.org/r/67136/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
