----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/#review203558 -----------------------------------------------------------
Patch looks great! Reviews applied: [67238] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 22, 2018, 12:13 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67238/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 12:13 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and > Vinod Kone. > > > Bugs: MESOS-8932 > https://issues.apache.org/jira/browse/MESOS-8932 > > > Repository: mesos > > > Description > ------- > > Fixed a quota-related metrics bug. > > > Diffs > ----- > > src/master/allocator/mesos/metrics.cpp > 5194f5b3b3f507b36f02300775230157db3dd477 > src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69 > > > Diff: https://reviews.apache.org/r/67238/diff/1/ > > > Testing > ------- > > `make check` passes > > Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, > fails without the metrics fix and passes with it. > > > Thanks, > > Greg Mann > >
