----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/#review203560 -----------------------------------------------------------
Fix it, then Ship it! Looks great! src/tests/master_tests.cpp Line 8542 (original), 8538 (patched) <https://reviews.apache.org/r/67217/#comment285846> `Ensure` src/tests/partition_tests.cpp Lines 3328 (patched) <https://reviews.apache.org/r/67217/#comment285847> Missing space before `slave1`. (same for the same comment above) - Benno Evers On May 18, 2018, 6:30 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67217/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 6:30 p.m.) > > > Review request for mesos, Benjamin Bannier and Benno Evers. > > > Bugs: MESOS-8923 > https://issues.apache.org/jira/browse/MESOS-8923 > > > Repository: mesos > > > Description > ------- > > An agent may retry `SlaveRegisteredMessage` if it does not receive > the registration confirmation on time. In this case the confirmation > may be sent twice. In tests with multiple registering agents, this > may result that an expectation set for one agent is satisfied by > a retried confirmation for another agent. > > This patch unifies the way how this case is handled. An expectation > is augmented with a matcher for with the agent pid for which the > expectation is set. > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > f3fb2244bd8f10a7bc0fe3400f96dc739f3db7ac > src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 > src/tests/partition_tests.cpp 390b7c8d0674d6f51a06507fdb720ba2fe95b642 > src/tests/persistent_volume_endpoints_tests.cpp > 770c4822d8c8ecbacdbd0c3d92a3cd2ff3837e3d > src/tests/storage_local_resource_provider_tests.cpp > 45cb38922f78941e82667a60b3b71ce220c9202f > > > Diff: https://reviews.apache.org/r/67217/diff/1/ > > > Testing > ------- > > `make check` on Mac OS 10.13.4 > > > Thanks, > > Alexander Rukletsov > >
