----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67207/#review203612 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On May 18, 2018, 2:07 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67207/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 2:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8499 > https://issues.apache.org/jira/browse/MESOS-8499 > > > Repository: mesos > > > Description > ------- > > The health check image used the official powershell image on nanoserver, > which hasn't been updated for Windows Version 1803, so health checks > were broken on 1803. To avoid issues like this in the future, we now > pull from the Mesos dockerhub repository with our own health check > image. The commands have also been changed to use the same one as Linux > (`curl` and `mesos-tcp-connect`). > > > Diffs > ----- > > src/checks/checker_process.hpp 228ac78715f120b43db05b5691412e8f5520de3b > src/checks/checker_process.cpp 7e484510b4fc2b94d4d4385dfa8f68bdd76e6093 > src/tests/environment.cpp a30592ac6b0002dad0947086ecbfdf4e2db62da5 > > > Diff: https://reviews.apache.org/r/67207/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >