----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67191/#review203653 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/future.hpp Line 1125 (original), 1129 (patched) <https://reviews.apache.org/r/67191/#comment285938> Let's add a `TODO` here, // TODO(chhsia0): Consider preserving the error type, see MESOS-8925. 3rdparty/libprocess/include/process/future.hpp Line 1135 (original), 1140 (patched) <https://reviews.apache.org/r/67191/#comment285939> Ditto. - Benjamin Bannier On May 22, 2018, 10:28 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67191/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 10:28 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, > and Zhitao Li. > > > Bugs: MESOS-8925 > https://issues.apache.org/jira/browse/MESOS-8925 > > > Repository: mesos > > > Description > ------- > > Supported custom error types for the `Future(Try<...>)` constructor. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > fb107d2bdf371f1c7ffb04e7387d7ddec13964cb > > > Diff: https://reviews.apache.org/r/67191/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
