----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/#review203679 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On May 16, 2018, 5:56 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67153/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 5:56 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-8792 > https://issues.apache.org/jira/browse/MESOS-8792 > > > Repository: mesos > > > Description > ------- > > If the operator omitted the `path` field from the `allowed_devices` > entry, the `cgroups/devices` isolator would silently ignore the > entry. Change this to an error to make the behavior consistent > with `linux/devices` and to make it clear to operators that the > configuration is incomplete. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp > 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0 > src/slave/containerizer/mesos/isolators/linux/devices.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67153/diff/3/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
