----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66958/#review203692 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On May 22, 2018, 3:51 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66958/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 3:51 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8674 > https://issues.apache.org/jira/browse/MESOS-8674 > > > Repository: mesos > > > Description > ------- > > subprocess_windows.cpp was creating inheritable pipes and files. On > Windows, our policy is to make everything not inheritable and then have > `CreateProcessW` set the the right pipes to be inheritable to avoid any > handle leaks. Now, subprocess_windows.cpp follows that inheritance > policy. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess_windows.cpp > a1e6425faff01f816748f0b8b5307612b6dd8302 > > > Diff: https://reviews.apache.org/r/66958/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
