----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66961/#review203697 -----------------------------------------------------------
Ship it! Awesome! 3rdparty/stout/tests/os/sendfile_tests.cpp Lines 68-73 (patched) <https://reviews.apache.org/r/66961/#comment285967> We're going to want to generalize this and my `struct Closer` soon-ish. Maybe when we make `int_fd` on Linux an RAII class... - Andrew Schwartzmeyer On May 22, 2018, 3:54 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66961/ > ----------------------------------------------------------- > > (Updated May 22, 2018, 3:54 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-3444 and MESOS-8681 > https://issues.apache.org/jira/browse/MESOS-3444 > https://issues.apache.org/jira/browse/MESOS-8681 > > > Repository: mesos > > > Description > ------- > > The sendfile tests were using socketpair, but the rest of the tests > were crossplatform. By providing a Windows socketpair implementations, > the tests are now ported. > > > Diffs > ----- > > 3rdparty/stout/tests/CMakeLists.txt > 43c5e873a3a3b8f79f0f888a450e186c6123d938 > 3rdparty/stout/tests/os/sendfile_tests.cpp > 05966ae067ae3972598da3370eb16fdce5736c21 > > > Diff: https://reviews.apache.org/r/66961/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
