----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203705 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp Lines 479-506 (patched) <https://reviews.apache.org/r/67137/#comment285988> I'd add a TODO to move this to stout. - Jie Yu On May 23, 2018, 10:25 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67137/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 10:25 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and James Peach. > > > Bugs: MESOS-8917 > https://issues.apache.org/jira/browse/MESOS-8917 > > > Repository: mesos > > > Description > ------- > > Avoided leaking file descriptors in Mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > f25d90651ef32495c9161c3eaed8a327d1b2b926 > > > Diff: https://reviews.apache.org/r/67137/diff/7/ > > > Testing > ------- > > `make check` > > I still need to confirm this patch in CI on a wider range of scenarios. > > > Thanks, > > Benjamin Bannier > >