> On May 23, 2018, 7:05 p.m., Jie Yu wrote: > > src/tests/containerizer/linux_devices_isolator_tests.cpp > > Lines 133 (patched) > > <https://reviews.apache.org/r/67145/diff/5/?file=2026758#file2026758line133> > > > > ```[jie@core-dev ~]$ echo $SUDO_USER > > > > ``` > > > > It does not exist on my linux box. > > > > ```[jie@core-dev ~]$ cat /etc/redhat-release > > CentOS Linux release 7.4.1708 (Core) ```
Discussed on slack. `sudo` will set `$SUDO_USER` when you run the tests as root by doing `sudo ./src/mesos-tests ...`. In this case, we need a non-root user that is on the system, and `$SUDO_USER` is the name of the user account that originally started the tests. I'm assuming that everyone will use `sudo` to run the tests as `root` rather than actually logging into a console as `root`. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67145/#review203678 ----------------------------------------------------------- On May 16, 2018, 12:30 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67145/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 12:30 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-8792 > https://issues.apache.org/jira/browse/MESOS-8792 > > > Repository: mesos > > > Description > ------- > > Added test to verify that the `linux/devices` isolator supports > populating devices that are whitelisted by the `allowed_devices` > agent flag. > > > Diffs > ----- > > src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 > src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc > src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67145/diff/5/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
